Suppress diff exceptions#167
Merged
Merged
Conversation
ishulgin
reviewed
Jun 2, 2026
| type: "diff", | ||
| oldText: oldContent, | ||
| newText: newContent, | ||
| path: change.path, |
Collaborator
There was a problem hiding this comment.
What if file was actually moved? Don't we want to use PatchChangeKind#moved_path?
Collaborator
Author
There was a problem hiding this comment.
Actually I think that it's impossible to express move in a single diff event. We probably need to split it into delete + add pair.
Collaborator
Author
There was a problem hiding this comment.
We need to discuss how to properly send moved files. For now we send moved_path + oldText/newText.
Let's fixup this in following PR.
SteffenDE
reviewed
Jun 3, 2026
incorrect assumption that add/diff changes may have unified diff
ishulgin
reviewed
Jun 5, 2026
| function isUnifiedDiff(content: string): boolean { | ||
| return content.startsWith("--- ") || content.includes("\n--- "); | ||
| async function createUpdateFileContent(change: FileUpdateChange): Promise<ToolCallContent | null> { | ||
| if (change.kind.type !== "update") return null; |
Collaborator
There was a problem hiding this comment.
We don't have similar guards in other execution branches. Let's drop it?
ishulgin
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.